fix: Remove use of blobfile for local files
#415
+15
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the need for the `blobfile` package when loading local files. Uses same approach as `blobfile` does for local file read.
hauntsaninja
requested changes
Sep 1, 2025
| url = urllib.parse.urlparse(blobpath) | ||
| if url.scheme is None or url.scheme == "": | ||
| with open(blobpath, "rb") as f: | ||
| with io.BufferedReader(f) as br: |
There was a problem hiding this comment.
could you remove this extra io.BufferedReader? it's redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the need for the
blobfilepackage when loading local files. Uses same approach asblobfiledoes for local file read. For local files this is generally not really providing any value as far as I can tell and introduces an additional dependency chain and logic around a simple file read.